Bug 188987 - Convert timeout values in WebKitTestRunner to WTF::Seconds
Summary: Convert timeout values in WebKitTestRunner to WTF::Seconds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-27 10:31 PDT by Simon Fraser (smfr)
Modified: 2018-08-27 14:18 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.27 KB, patch)
2018-08-27 10:34 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (22.29 KB, patch)
2018-08-27 10:52 PDT, Simon Fraser (smfr) 		rniwa: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (771.53 KB, application/zip)
2018-08-27 12:06 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (1.42 MB, application/zip)
2018-08-27 12:09 PDT, EWS Watchlist 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-08-27 10:31:03 PDT 
Convert timeout values in WebKitTestRunner to WTF::Seconds
Comment 1 Simon Fraser (smfr) 2018-08-27 10:34:52 PDT 
Created attachment 348158 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-27 10:52:07 PDT 
Created attachment 348164 [details]
Patch
Comment 3 Ryosuke Niwa 2018-08-27 10:53:25 PDT 
Comment on attachment 348164 [details]
Patch

r=ms assuming EWS says it's good.
Comment 4 EWS Watchlist 2018-08-27 12:06:34 PDT 
Comment on attachment 348164 [details]
Patch

Attachment 348164 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8997685

Number of test failures exceeded the failure limit.
Comment 5 EWS Watchlist 2018-08-27 12:06:36 PDT 
Created attachment 348181 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 EWS Watchlist 2018-08-27 12:09:05 PDT 
Comment on attachment 348164 [details]
Patch

Attachment 348164 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8998186

Number of test failures exceeded the failure limit.
Comment 7 EWS Watchlist 2018-08-27 12:09:07 PDT 
Created attachment 348183 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 8 Simon Fraser (smfr) 2018-08-27 14:16:33 PDT 
https://trac.webkit.org/r235399
Comment 9 Radar WebKit Bug Importer 2018-08-27 14:18:14 PDT 
<rdar://problem/43769169>