188949 – [Apple Pay] Introduce new values for -apple-pay-button-type

Bug 188949 - [Apple Pay] Introduce new values for -apple-pay-button-type

Summary: [Apple Pay] Introduce new values for -apple-pay-button-type

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andy Estes

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2018-08-25 13:41 PDT by Andy Estes
Modified:	2018-08-27 13:13 PDT (History)
CC List:	11 users (show)

See Also:

Attachments
Patch (92.12 KB, patch) 2018-08-25 13:50 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.87 MB, application/zip) 2018-08-25 15:16 PDT, EWS Watchlist	no flags	Details
Patch (146.37 KB, patch) 2018-08-25 15:46 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (223.61 KB, patch) 2018-08-26 19:01 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (223.55 KB, patch) 2018-08-26 19:53 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Estes 2018-08-25 13:41:13 PDT

[Apple Pay] Introduce new values for -apple-pay-button-type

Comment 1 Andy Estes 2018-08-25 13:43:04 PDT

rdar://problem/39992228

Comment 2 Andy Estes 2018-08-25 13:50:29 PDT Comment hidden (obsolete)

Created attachment 348082 [details]
Patch

Comment 3 EWS Watchlist 2018-08-25 15:16:05 PDT Comment hidden (obsolete)

Comment on attachment 348082 [details]
Patch

Attachment 348082 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8983360

New failing tests:
http/tests/ssl/applepay/ApplePayButton.html

Comment 4 EWS Watchlist 2018-08-25 15:16:07 PDT Comment hidden (obsolete)

Created attachment 348083 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 5 Andy Estes 2018-08-25 15:46:18 PDT Comment hidden (obsolete)

Created attachment 348085 [details]
Patch

Comment 6 Andy Estes 2018-08-26 19:01:58 PDT Comment hidden (obsolete)

Created attachment 348110 [details]
Patch

Comment 7 Andy Estes 2018-08-26 19:53:43 PDT

Created attachment 348111 [details]
Patch

Comment 8 WebKit Commit Bot 2018-08-26 20:32:57 PDT

Comment on attachment 348111 [details]
Patch

Clearing flags on attachment: 348111

Committed r235349: <https://trac.webkit.org/changeset/235349>

Comment 9 WebKit Commit Bot 2018-08-26 20:32:59 PDT

All reviewed patches have been landed.  Closing bug.

Comment 10 Simon Fraser (smfr) 2018-08-27 13:13:24 PDT

Comment on attachment 348111 [details]
Patch

Test is mostly useless since we don't run pixel tests.