Bug 188939 - Fix authentication for clients of WKPageLoaderClient after r234941
Summary: Fix authentication for clients of WKPageLoaderClient after r234941
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-24 17:33 PDT by Alex Christensen
Modified: 2018-08-27 08:45 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.16 KB, patch)
2018-08-24 17:42 PDT, Alex Christensen 		youennf: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-24 17:33:58 PDT 
Fix authentication for clients of WKPageLoaderClient after r234941
Comment 1 Alex Christensen 2018-08-24 17:42:37 PDT 
Created attachment 348063 [details]
Patch
Comment 2 youenn fablet 2018-08-24 18:23:51 PDT 
Comment on attachment 348063 [details]
Patch

LGTM.
We should increase our testing of unimplemented callbacks config through API tests so that our defaults do not change.
In that particular case, that would require launching the http server...
Comment 3 Alex Christensen 2018-08-27 08:44:30 PDT 
http://trac.webkit.org/r235364
Comment 4 Radar WebKit Bug Importer 2018-08-27 08:45:17 PDT 
<rdar://problem/43755378>