Bug 188870 - HTML{Image, Link, Script}Element::crossOrigin() should return an AtomicString
Summary: HTML{Image, Link, Script}Element::crossOrigin() should return an AtomicString
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-22 17:01 PDT by Daniel Bates
Modified: 2023-09-25 08:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.74 KB, patch)
2018-08-22 17:09 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-08-22 17:01:28 PDT 
HTML{Image, Link, Script}Element::crossOrigin() should return an "const AtomicString&" as opposed to a String so as to avoid unnecessary ref-count churn and the need for a caller to perform string comparisons.
Comment 1 Daniel Bates 2018-08-22 17:09:18 PDT 
Created attachment 347878 [details]
Patch
Comment 2 Ahmad Saleem 2023-09-20 09:05:23 PDT 
Do we need this now? - @Ryosuke & @Chris?
Comment 3 Ryosuke Niwa 2023-09-25 08:44:44 PDT 
We don't need to do this per se.