RESOLVED INVALID188863
Remove privateBrowsingEnabled from NetworkProcessCreationParameters 
https://bugs.webkit.org/show_bug.cgi?id=188863
Summary Remove privateBrowsingEnabled from NetworkProcessCreationParameters
Sihui Liu
Reported 2018-08-22 13:58:35 PDT
We should send a message to network process to create a privateBrowsing session instead of using the creation parameter.
Attachments
Patch (4.96 KB, patch)
2018-08-22 14:01 PDT, Sihui Liu 		achristensen: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sihui Liu
Comment 1 2018-08-22 14:01:49 PDT
Created attachment 347844 [details] Patch
Alex Christensen
Comment 2 2018-08-23 11:09:40 PDT
Comment on attachment 347844 [details] Patch This doesn't accomplish anything useful except separating a message into two messages.
Sihui Liu
Comment 3 2018-08-23 16:16:09 PDT
I was trying to remove the whole networkProcessCreationParameters, aiming to stop the initializing network process from processPool. But it seems we still need to send a lot of setting messages through webprocesspool, so I am not sure if this is a correct idea now...
Alex Christensen
Comment 4 2018-08-23 16:30:57 PDT
Comment on attachment 347844 [details] Patch You only need to remove the NetworkProcessCreationParameters members that come from a WebProcessPool. This one comes from a static function WebPreferences::anyPagesAreUsingPrivateBrowsing
Note You need to log in before you can comment on or make changes to this bug.