Bug 188863 - Remove privateBrowsingEnabled from NetworkProcessCreationParameters
Summary: Remove privateBrowsingEnabled from NetworkProcessCreationParameters
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-22 13:58 PDT by Sihui Liu
Modified: 2018-09-13 11:21 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.96 KB, patch)
2018-08-22 14:01 PDT, Sihui Liu 		achristensen: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-08-22 13:58:35 PDT 
We should send a message to network process to create a privateBrowsing session instead of using the creation parameter.
Comment 1 Sihui Liu 2018-08-22 14:01:49 PDT 
Created attachment 347844 [details]
Patch
Comment 2 Alex Christensen 2018-08-23 11:09:40 PDT 
Comment on attachment 347844 [details]
Patch

This doesn't accomplish anything useful except separating a message into two messages.
Comment 3 Sihui Liu 2018-08-23 16:16:09 PDT 
I was trying to remove the whole networkProcessCreationParameters, aiming to stop the initializing network process from processPool. But it seems we still need to send a lot of setting messages through webprocesspool, so I am not sure if this is a correct idea now...
Comment 4 Alex Christensen 2018-08-23 16:30:57 PDT 
Comment on attachment 347844 [details]
Patch

You only need to remove the NetworkProcessCreationParameters members that come from a WebProcessPool.  This one comes from a static function WebPreferences::anyPagesAreUsingPrivateBrowsing