Bug 188850 - [CoordGraphics] Drop old-school PlatformLayer management in CoordinatedGraphicsLayer
Summary: [CoordGraphics] Drop old-school PlatformLayer management in CoordinatedGraphi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 187385
  Show dependency tree / graph
 
Reported: 2018-08-22 09:11 PDT by Zan Dobersek
Modified: 2018-08-22 23:31 PDT (History)
9 users (show)

See Also:

Attachments
Patch (8.86 KB, patch)
2018-08-22 09:18 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (8.78 KB, patch)
2018-08-22 23:29 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-08-22 09:11:26 PDT 
[CoordGraphics] Drop old-school PlatformLayer management in CoordinatedGraphicsLayer
Comment 1 Zan Dobersek 2018-08-22 09:18:17 PDT 
Created attachment 347804 [details]
Patch
Comment 2 EWS Watchlist 2018-08-22 09:20:43 PDT 
Attachment 347804 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:113:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2018-08-22 23:29:15 PDT 
Created attachment 347908 [details]
Patch for landing
Comment 4 Zan Dobersek 2018-08-22 23:30:09 PDT 
Comment on attachment 347908 [details]
Patch for landing

Clearing flags on attachment: 347908

Committed r235219: <https://trac.webkit.org/changeset/235219>
Comment 5 Zan Dobersek 2018-08-22 23:30:12 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-08-22 23:31:28 PDT 
<rdar://problem/43633894>