Bug 188827 - Translate 4 tests using WKPageLoaderClient to ObjC
Summary: Translate 4 tests using WKPageLoaderClient to ObjC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 16:33 PDT by Alex Christensen
Modified: 2018-08-27 12:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (74.37 KB, patch)
2018-08-21 16:38 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch that applies (73.91 KB, patch)
2018-08-21 16:57 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (73.93 KB, patch)
2018-08-21 17:20 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (74.48 KB, patch)
2018-08-27 09:02 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Build fix (1.88 KB, patch)
2018-08-27 09:28 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (75.27 KB, patch)
2018-08-27 11:13 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch with updated title (74.81 KB, patch)
2018-08-27 11:14 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-21 16:33:34 PDT 
Translate 4 tests using WKPageLoaderClient to ObjC
Comment 1 Alex Christensen 2018-08-21 16:38:44 PDT 
Created attachment 347725 [details]
Patch
Comment 2 Alex Christensen 2018-08-21 16:57:40 PDT 
Created attachment 347730 [details]
patch that applies
Comment 3 Alex Christensen 2018-08-21 17:20:19 PDT 
Created attachment 347739 [details]
patch
Comment 4 Tim Horton 2018-08-21 17:32:34 PDT 
Comment on attachment 347739 [details]
patch

rs=me
Comment 5 Alex Christensen 2018-08-27 09:02:37 PDT 
Created attachment 348145 [details]
Patch
Comment 6 Alex Christensen 2018-08-27 09:08:39 PDT 
I don't know why it's having such a hard time applying the patch.
http://trac.webkit.org/r235367
Comment 7 Radar WebKit Bug Importer 2018-08-27 09:09:21 PDT 
<rdar://problem/43756020>
Comment 8 Don Olmstead 2018-08-27 09:23:23 PDT 
This broke the CMake builds
Comment 9 Don Olmstead 2018-08-27 09:28:10 PDT 
Created attachment 348150 [details]
Build fix

Files didn't get removed from CMake.
Comment 10 Don Olmstead 2018-08-27 09:30:34 PDT 
Alex beat me to the fix. Marking as resolved
Comment 11 Alex Christensen 2018-08-27 11:13:30 PDT 
Reopening to attach new patch.
Comment 12 Alex Christensen 2018-08-27 11:13:30 PDT 
Created attachment 348168 [details]
Patch
Comment 13 Alex Christensen 2018-08-27 11:14:25 PDT 
Created attachment 348169 [details]
patch with updated title
Comment 14 Alex Christensen 2018-08-27 12:38:45 PDT 
https://trac.webkit.org/changeset/235391/webkit