Bug 188824 - Web Inspector: Address some ESLint warnings
Summary: Web Inspector: Address some ESLint warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 15:40 PDT by Joseph Pecoraro
Modified: 2018-09-10 16:48 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (26.14 KB, patch)
2018-08-21 15:41 PDT, Joseph Pecoraro 		mattbaker: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-08-21 15:40:54 PDT 
Address some ESLint warnings

A few were real logic mistakes.
Comment 1 Joseph Pecoraro 2018-08-21 15:41:46 PDT 
Created attachment 347715 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2018-08-21 15:55:28 PDT 
Comment on attachment 347715 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=347715&action=review

r=me

> Source/WebInspectorUI/UserInterface/Controllers/AuditManager.js:39
> +            if (!(newTestSuite instanceof WI.AuditTestSuite))

Yikes
Comment 3 Joseph Pecoraro 2018-09-10 16:47:59 PDT 
<https://trac.webkit.org/changeset/235873/webkit>
Comment 4 Radar WebKit Bug Importer 2018-09-10 16:48:47 PDT 
<rdar://problem/44322766>