Bug 188786 - [GStreamer] Extra ASSERTs at MainThreadNotifier
Summary: [GStreamer] Extra ASSERTs at MainThreadNotifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-21 05:08 PDT by Xabier Rodríguez Calvar
Modified: 2018-09-06 03:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.75 KB, patch)
2018-08-21 05:10 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch for landing (1.76 KB, patch)
2018-09-06 03:11 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2018-08-21 05:08:09 PDT 
[GStreamer] Extra ASSERTs at MainThreadNotifier
Comment 1 Xabier Rodríguez Calvar 2018-08-21 05:10:07 PDT 
Created attachment 347630 [details]
Patch

It looks like the MainThread notifier could have these two extra checks in debug mode.
Comment 2 EWS Watchlist 2018-08-21 05:11:29 PDT 
Attachment 347630 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xabier Rodríguez Calvar 2018-08-21 05:12:23 PDT 
(In reply to Build Bot from comment #2)
> ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and
> description  [changelog/filechangedescriptionwhitespace] [5]
> ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and
> description  [changelog/filechangedescriptionwhitespace] [5]
> Total errors found: 2 in 2 files

Weird, local check said nothing...
Comment 4 Xabier Rodríguez Calvar 2018-09-06 03:11:39 PDT 
Created attachment 349012 [details]
Patch for landing
Comment 5 Xabier Rodríguez Calvar 2018-09-06 03:12:53 PDT 
(In reply to Xabier Rodríguez Calvar from comment #3)
> (In reply to Build Bot from comment #2)
> > ERROR: Source/WebCore/ChangeLog:9:  Need whitespace between colon and
> > description  [changelog/filechangedescriptionwhitespace] [5]
> > ERROR: Source/WebCore/ChangeLog:10:  Need whitespace between colon and
> > description  [changelog/filechangedescriptionwhitespace] [5]
> > Total errors found: 2 in 2 files
> 
> Weird, local check said nothing...

Because style checks are done before opening the changelogs.
Comment 6 WebKit Commit Bot 2018-09-06 03:50:48 PDT 
Comment on attachment 349012 [details]
Patch for landing

Clearing flags on attachment: 349012

Committed r235732: <https://trac.webkit.org/changeset/235732>
Comment 7 WebKit Commit Bot 2018-09-06 03:50:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-09-06 03:51:32 PDT 
<rdar://problem/44176399>