Bug 188749 - UIWebView crash when enter/exit fullscreen happens too quickly.
Summary: UIWebView crash when enter/exit fullscreen happens too quickly.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-20 11:07 PDT by Jeremy Jones
Modified: 2018-08-27 13:25 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.65 KB, patch)
2018-08-20 11:44 PDT, Jeremy Jones
jer.noble: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.09 MB, application/zip)
2018-08-20 13:10 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews202 for win-future (12.93 MB, application/zip)
2018-08-20 14:29 PDT, EWS Watchlist
no flags Details
Patch for landing. (9.64 KB, patch)
2018-08-27 12:59 PDT, Jeremy Jones
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2018-08-20 11:07:20 PDT
When enter/exit video fullscreen happens on a <video> element in UIWebView too quickly, there is a null-pointer dereference.
Comment 1 Jeremy Jones 2018-08-20 11:44:11 PDT
Created attachment 347518 [details]
Patch
Comment 2 EWS Watchlist 2018-08-20 13:10:42 PDT
Comment on attachment 347518 [details]
Patch

Attachment 347518 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8920363

New failing tests:
accessibility/smart-invert-reference.html
Comment 3 EWS Watchlist 2018-08-20 13:10:43 PDT
Created attachment 347535 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 4 WebKit Commit Bot 2018-08-20 14:09:35 PDT
Comment on attachment 347518 [details]
Patch

Rejecting attachment 347518 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 347518, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=347518&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=188749&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 347518 from bug 188749.
Fetching: https://bugs.webkit.org/attachment.cgi?id=347518
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/media/ios/media-fullscreen-return-to-inline-expected.txt
	A	LayoutTests/media/ios/media-fullscreen-return-to-inline.html
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: 74c8d62097782554b01f11f78e804309e8a9540d and refs/remotes/origin/master differ, using rebase:
:040000 040000 68df6db74f138028de376a7427a398ee8aed65d9 433d2bfae20da9110100150acc36e4f7084310c8 M	LayoutTests
:040000 040000 d2337fbca869b4b80410a409c3dba4ed974b0232 0a3e642afd8f4605c1fc2a7a82d2eba47d5cc515 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	A	LayoutTests/media/ios/media-fullscreen-return-to-inline-expected.txt
	A	LayoutTests/media/ios/media-fullscreen-return-to-inline.html
	M	LayoutTests/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/LayoutTests/ChangeLog' is out of date
W: 74c8d62097782554b01f11f78e804309e8a9540d and refs/remotes/origin/master differ, using rebase:
:040000 040000 68df6db74f138028de376a7427a398ee8aed65d9 433d2bfae20da9110100150acc36e4f7084310c8 M	LayoutTests
:040000 040000 d2337fbca869b4b80410a409c3dba4ed974b0232 0a3e642afd8f4605c1fc2a7a82d2eba47d5cc515 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/8921069
Comment 5 EWS Watchlist 2018-08-20 14:29:01 PDT
Comment on attachment 347518 [details]
Patch

Attachment 347518 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8920871

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 6 EWS Watchlist 2018-08-20 14:29:12 PDT
Created attachment 347544 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 7 Jeremy Jones 2018-08-27 12:59:53 PDT
Created attachment 348190 [details]
Patch for landing.
Comment 8 WebKit Commit Bot 2018-08-27 13:25:07 PDT
Comment on attachment 348190 [details]
Patch for landing.

Rejecting attachment 348190 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 348190, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8999373