NEW188737
Forgetting to call noResult in DFGSpeculativeJIT leads to hard to diagnose crashes 
https://bugs.webkit.org/show_bug.cgi?id=188737
Summary Forgetting to call noResult in DFGSpeculativeJIT leads to hard to diagnose cr...
Saam Barati
Reported 2018-08-19 18:33:58 PDT
We should probably just make the thing that calls compileNode do this. I just spend 30 minutes figuring out why a crash was happening, and it was because I forgot to call noResult(node) for a node I'm implementing.
Attachments
Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2018-08-19 22:03:35 PDT
We pass various arguments to noResult that could be hard to infer. We should probably just have an assert that it gets called exactly once for each node that doesn't have a result
Note You need to log in before you can comment on or make changes to this bug.