Bug 188737 - Forgetting to call noResult in DFGSpeculativeJIT leads to hard to diagnose crashes
Summary: Forgetting to call noResult in DFGSpeculativeJIT leads to hard to diagnose cr...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-19 18:33 PDT by Saam Barati
Modified: 2018-08-19 22:03 PDT (History)
11 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-08-19 18:33:58 PDT 
We should probably just make the thing that calls compileNode do this.

I just spend 30 minutes figuring out why a crash was happening, and it was because I forgot to call noResult(node) for a node I'm implementing.
Comment 1 Saam Barati 2018-08-19 22:03:35 PDT 
We pass various arguments to noResult that could be hard to infer. We should probably just have an assert that it gets called exactly once for each node that doesn't have a result