Bug 188604 - Remove unused subresourceIntegrityEnabled setting/preference
Summary: Remove unused subresourceIntegrityEnabled setting/preference
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-15 09:22 PDT by Alex Christensen
Modified: 2018-08-16 09:32 PDT (History)
8 users (show)

See Also:


Attachments
Patch (4.49 KB, patch)
2018-08-15 09:23 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2018-08-15 09:34 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-sierra (2.30 MB, application/zip)
2018-08-15 10:37 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.79 MB, application/zip)
2018-08-15 10:48 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (3.02 MB, application/zip)
2018-08-15 11:21 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.25 MB, application/zip)
2018-08-15 11:33 PDT, EWS Watchlist
no flags Details
Patch (9.05 KB, patch)
2018-08-15 11:49 PDT, Alex Christensen
achristensen: review-
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-sierra (2.43 MB, application/zip)
2018-08-15 13:10 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.61 MB, application/zip)
2018-08-15 13:22 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews114 for mac-sierra (3.14 MB, application/zip)
2018-08-15 13:25 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.25 MB, application/zip)
2018-08-15 14:11 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-15 09:22:49 PDT
Remove unused subresourceIntegrityEnabled setting/preference
Comment 1 Alex Christensen 2018-08-15 09:23:19 PDT
Created attachment 347165 [details]
Patch
Comment 2 Alex Christensen 2018-08-15 09:34:54 PDT
Created attachment 347167 [details]
Patch
Comment 3 EWS Watchlist 2018-08-15 10:37:43 PDT
Comment on attachment 347167 [details]
Patch

Attachment 347167 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8868845

New failing tests:
http/tests/subresource-integrity/sri-disabled-with-setting.html
Comment 4 EWS Watchlist 2018-08-15 10:37:45 PDT
Created attachment 347174 [details]
Archive of layout-test-results from ews101 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-08-15 10:48:25 PDT
Comment on attachment 347167 [details]
Patch

Attachment 347167 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8868892

New failing tests:
http/tests/subresource-integrity/sri-disabled-with-setting.html
Comment 6 EWS Watchlist 2018-08-15 10:48:27 PDT
Created attachment 347176 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-08-15 11:21:02 PDT
Comment on attachment 347167 [details]
Patch

Attachment 347167 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8869048

New failing tests:
http/tests/subresource-integrity/sri-disabled-with-setting.html
Comment 8 EWS Watchlist 2018-08-15 11:21:03 PDT
Created attachment 347179 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 9 EWS Watchlist 2018-08-15 11:33:13 PDT
Comment on attachment 347167 [details]
Patch

Attachment 347167 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8869079

New failing tests:
http/tests/subresource-integrity/sri-disabled-with-setting.html
Comment 10 EWS Watchlist 2018-08-15 11:33:15 PDT
Created attachment 347181 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 11 Daniel Bates 2018-08-15 11:35:16 PDT
Title is misleading. The setting is used. It is just enabled by default. Although I don’t recall many issues with subresource integrity having a setting to toggle “a security policy” feature is always nice for debugging and triaging.
Comment 12 Alex Christensen 2018-08-15 11:49:31 PDT
Created attachment 347185 [details]
Patch
Comment 13 Alex Christensen 2018-08-15 13:04:55 PDT
I think it's unused code, but if you feel that it's useful to have around, Dan, feel free to r-
Comment 14 EWS Watchlist 2018-08-15 13:10:17 PDT
Comment on attachment 347185 [details]
Patch

Attachment 347185 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8870645

New failing tests:
http/tests/subresource-integrity/sri-enabled-with-setting.html
Comment 15 EWS Watchlist 2018-08-15 13:10:19 PDT
Created attachment 347197 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 16 EWS Watchlist 2018-08-15 13:22:04 PDT
Comment on attachment 347185 [details]
Patch

Attachment 347185 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8870709

New failing tests:
http/tests/subresource-integrity/sri-enabled-with-setting.html
Comment 17 EWS Watchlist 2018-08-15 13:22:06 PDT
Created attachment 347200 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 18 EWS Watchlist 2018-08-15 13:25:36 PDT
Comment on attachment 347185 [details]
Patch

Attachment 347185 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8870546

New failing tests:
http/tests/subresource-integrity/sri-enabled-with-setting.html
Comment 19 EWS Watchlist 2018-08-15 13:25:38 PDT
Created attachment 347202 [details]
Archive of layout-test-results from ews114 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 20 EWS Watchlist 2018-08-15 14:11:13 PDT
Comment on attachment 347185 [details]
Patch

Attachment 347185 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8871016

New failing tests:
http/tests/subresource-integrity/sri-enabled-with-setting.html
Comment 21 EWS Watchlist 2018-08-15 14:11:15 PDT
Created attachment 347208 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4