Bug 188582 - HashMap<Ref<P>, V> asserts when V is not zero for its empty value
Summary: HashMap<Ref<P>, V> asserts when V is not zero for its empty value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 188426
  Show dependency tree / graph
 
Reported: 2018-08-14 15:19 PDT by Saam Barati
Modified: 2018-08-23 11:32 PDT (History)
17 users (show)

See Also:

Attachments
patch (6.99 KB, patch)
2018-08-14 18:25 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-08-14 15:19:27 PDT 
Basically, we end up with code that does this:

Ref<P>(Ref<P>(HashTableEmptyValue))

Which:
- invokes move constructor on an incoming empty value
- that incoming empty value has nullptr for m_ptr
- The move constructor calls leakRef on the incoming value
- leakRef does: ASSERT(m_ptr)
Comment 1 Saam Barati 2018-08-14 18:25:16 PDT 
Created attachment 347141 [details]
patch
Comment 2 WebKit Commit Bot 2018-08-14 21:08:15 PDT 
Comment on attachment 347141 [details]
patch

Clearing flags on attachment: 347141

Committed r234879: <https://trac.webkit.org/changeset/234879>
Comment 3 WebKit Commit Bot 2018-08-14 21:08:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-14 21:09:20 PDT 
<rdar://problem/43318499>