Bug 188576 - Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithHSTSCache
Summary: Crash in WebKit::filterPreloadHSTSEntry via NetworkProcess::getHostNamesWithH...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-14 13:34 PDT by Sihui Liu
Modified: 2018-08-14 17:55 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.40 KB, patch)
2018-08-14 13:38 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (9.24 KB, patch)
2018-08-14 16:46 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
patch (9.33 KB, patch)
2018-08-14 17:16 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-08-14 13:34:28 PDT 
Called on an invalid object.
Comment 1 Sihui Liu 2018-08-14 13:34:45 PDT 
<rdar://problem/43148977>
Comment 2 Sihui Liu 2018-08-14 13:38:32 PDT 
Created attachment 347107 [details]
Patch
Comment 3 Chris Dumez 2018-08-14 14:36:50 PDT 
Why no api test?
Comment 4 Alex Christensen 2018-08-14 15:03:35 PDT 
Comment on attachment 347107 [details]
Patch

I agree.  This should have an API test, and that would be easy to write.
Comment 5 Ryosuke Niwa 2018-08-14 15:53:07 PDT 
Comment on attachment 347107 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347107&action=review

> Source/WebKit/ChangeLog:3
> +        CrashTracer: [USER] com.apple.WebKit.Networking.Development at com.apple.WebKit: WTF::HashTable<WTF::String, WTF::String, WTF::IdentityExtractor, WTF::StringHash, WTF::HashTraits<WTF::String>, WTF::HashTraits<WTF::String> >::add + 26

Bugzilla title shouldn't refer to things like CrashTracer.
Comment 6 Sihui Liu 2018-08-14 16:46:32 PDT 
Created attachment 347130 [details]
Patch
Comment 7 Sihui Liu 2018-08-14 16:48:30 PDT 
(In reply to Alex Christensen from comment #4)
> Comment on attachment 347107 [details]
> Patch
> 
> I agree.  This should have an API test, and that would be easy to write.

Test added.
Comment 8 Alex Christensen 2018-08-14 17:16:03 PDT 
Created attachment 347134 [details]
patch
Comment 9 WebKit Commit Bot 2018-08-14 17:55:26 PDT 
Comment on attachment 347134 [details]
patch

Clearing flags on attachment: 347134

Committed r234875: <https://trac.webkit.org/changeset/234875>
Comment 10 WebKit Commit Bot 2018-08-14 17:55:27 PDT 
All reviewed patches have been landed.  Closing bug.