Crashes in Quip under _dictionaryPopupInfoForRange, in setObject:forKey:
Created attachment 347097 [details] Patch
Comment on attachment 347097 [details] Patch Since this is speculative, I think a comment mentioning the radar might be helpful.
I'm going to refrain from adding a comment for two reasons: 1) it'll definitely fix the crash; there's no longer any way to get nil in the setObject:forKey:, and 2) we'll never revisit this, so the comment will live forever. The speculativeness is more about the "how we got here" than the fix.
Thank you for your review!
Comment on attachment 347097 [details] Patch Rejecting attachment 347097 [details] from review queue. megan_gardner@apple.com does not have reviewer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
<rdar://problem/34201095>
Comment on attachment 347097 [details] Patch Clearing flags on attachment: 347097 Committed r234900: <https://trac.webkit.org/changeset/234900>
All reviewed patches have been landed. Closing bug.