Bug 188541 - [LFC][Floating] Do not confuse clear with clearance.
Summary: [LFC][Floating] Do not confuse clear with clearance.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-13 18:24 PDT by zalan
Modified: 2018-08-13 18:48 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.93 KB, patch)
2018-08-13 18:28 PDT, zalan 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-13 18:24:28 PDT 
clear -> clear property
clearance -> the offset required to avoid floats when clear is present.
Comment 1 zalan 2018-08-13 18:28:51 PDT 
Created attachment 347060 [details]
Patch
Comment 2 Simon Fraser (smfr) 2018-08-13 18:37:37 PDT 
Comment on attachment 347060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347060&action=review

> Source/WebCore/layout/blockformatting/BlockFormattingContext.h:60
> +    void computeVerticalPositionForClear(const FloatingContext&, const Box&, Display::Box&) const;

I would like to see the word "float" somewhere in the function name.

> Source/WebCore/layout/layouttree/LayoutBox.h:65
> +    bool hasClear() const;

This name sounds a bit too generic. Maybe hasFloatClear, or clearsFloats?
Comment 3 zalan 2018-08-13 18:47:43 PDT 
Committed r234834: <https://trac.webkit.org/changeset/234834>
Comment 4 Radar WebKit Bug Importer 2018-08-13 18:48:18 PDT 
<rdar://problem/43264418>