Bug 188538 - Allow the substring 'me' in contributor names and email addresses
Summary: Allow the substring 'me' in contributor names and email addresses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thomas Denney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-13 15:30 PDT by Thomas Denney
Modified: 2018-08-13 16:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2018-08-13 15:31 PDT, Thomas Denney 		no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2018-08-13 15:45 PDT, Thomas Denney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Denney 2018-08-13 15:30:09 PDT 
Allow the substring 'me' in contributor names and email addresses
Comment 1 Thomas Denney 2018-08-13 15:31:56 PDT 
Created attachment 347050 [details]
Patch
Comment 2 EWS Watchlist 2018-08-13 15:34:03 PDT 
Attachment 347050 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Tools/ChangeLog:8:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: fuzz test  [changelog/unwantedsecurityterms] [3]
Total errors found: 3 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2018-08-13 15:38:46 PDT 
Comment on attachment 347050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347050&action=review

Other than that r=me

> Tools/ChangeLog:8
> +		A fuzz test didn't permit the string "me" in email addresses or names of

TABS‽ TABS‽
Comment 4 Thomas Denney 2018-08-13 15:45:18 PDT 
Created attachment 347052 [details]
Patch
Comment 5 Tim Horton 2018-08-13 15:47:34 PDT 
(In reply to Build Bot from comment #2)
> security-sensitive phrasing could help someone exploit WebKit: fuzz test 
> [changelog/unwantedsecurityterms] [3]

HA
Comment 6 WebKit Commit Bot 2018-08-13 16:15:12 PDT 
Comment on attachment 347052 [details]
Patch

Clearing flags on attachment: 347052

Committed r234824: <https://trac.webkit.org/changeset/234824>
Comment 7 WebKit Commit Bot 2018-08-13 16:15:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-08-13 16:17:17 PDT 
<rdar://problem/43258117>