Bug 188534 - Web Inspector: Table should handle row selection instead of the table delegate
Summary: Web Inspector: Table should handle row selection instead of the table delegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-13 14:47 PDT by Matt Baker
Modified: 2018-08-13 15:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.00 KB, patch)
2018-08-13 14:54 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Patch for landing (5.03 KB, patch)
2018-08-13 15:05 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-08-13 14:47:33 PDT 
To prevent selection, the table delegate can implement `tableShouldSelectRow`, similar to NSTableViewDelegate's shouldSelectRow.
Comment 1 Radar WebKit Bug Importer 2018-08-13 14:47:57 PDT 
<rdar://problem/43253335>
Comment 2 Matt Baker 2018-08-13 14:54:18 PDT 
Created attachment 347043 [details]
Patch
Comment 3 Joseph Pecoraro 2018-08-13 15:01:36 PDT 
Comment on attachment 347043 [details]
Patch

r=me
Comment 4 Joseph Pecoraro 2018-08-13 15:02:29 PDT 
Comment on attachment 347043 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=347043&action=review

> Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js:43
> +    tableShouldSelectRow(table, cell, column, rowIndex)

This should be under the delegate section (~20 lines down), not the data source.
Comment 5 Matt Baker 2018-08-13 15:05:23 PDT 
Created attachment 347047 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-08-13 15:44:25 PDT 
Comment on attachment 347047 [details]
Patch for landing

Clearing flags on attachment: 347047

Committed r234822: <https://trac.webkit.org/changeset/234822>
Comment 7 WebKit Commit Bot 2018-08-13 15:44:26 PDT 
All reviewed patches have been landed.  Closing bug.