Bug 188526 - Improve error message in check-webkit-style when adding contributors
Summary: Improve error message in check-webkit-style when adding contributors
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-13 12:16 PDT by Thomas Denney
Modified: 2018-08-29 17:24 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Denney 2018-08-13 12:16:08 PDT 
Currently when you add a contributor to constributors.json you will see the following error message:

    ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax]

The script should (a) only produce an error when trying to change committee members and (b) only output the error if you are already a committer (in which case you should commit directly).