Bug 188492 - [LFC][Floating] Add basic clearance support
Summary: [LFC][Floating] Add basic clearance support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-12 15:37 PDT by zalan
Modified: 2018-08-13 07:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (19.58 KB, patch)
2018-08-12 16:25 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-12 15:37:17 PDT 
ssia
Comment 1 zalan 2018-08-12 16:25:12 PDT 
Created attachment 346991 [details]
Patch
Comment 2 Antti Koivisto 2018-08-13 07:28:54 PDT 
Comment on attachment 346991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346991&action=review

> Source/WebCore/layout/FloatingState.h:87
> +    enum class FloatStack { Left, Right, Both };

Maybe call this something else than "stack"? It sounds like a data structure.
Comment 3 Antti Koivisto 2018-08-13 07:30:01 PDT 
https://www.youtube.com/watch?v=MQ9iPTu_FMA
Comment 4 zalan 2018-08-13 07:48:17 PDT 
Committed r234800: <https://trac.webkit.org/changeset/234800>
Comment 5 Radar WebKit Bug Importer 2018-08-13 07:49:20 PDT 
<rdar://problem/43232348>