Bug 188473 - webkit-patch setup-git-clone should set Git core editor to commit-log-editor
Summary: webkit-patch setup-git-clone should set Git core editor to commit-log-editor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-10 10:01 PDT by Daniel Bates
Modified: 2018-08-10 14:49 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.19 KB, patch)
2018-08-10 10:05 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-08-10 10:01:38 PDT 
We should have "webkit-patch setup-git-clone" configure the Git core editor to use Tools/Scripts/commit-log-editor. This will ensure that the Git commit message will have the proper format for developers that choose to manually generate their ChangeLog using prepare-ChangeLog.
Comment 1 Daniel Bates 2018-08-10 10:05:22 PDT 
Created attachment 346907 [details]
Patch
Comment 2 Daniel Bates 2018-08-10 14:48:45 PDT 
Comment on attachment 346907 [details]
Patch

Clearing flags on attachment: 346907

Committed r234770: <https://trac.webkit.org/changeset/234770>
Comment 3 Daniel Bates 2018-08-10 14:48:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-10 14:49:17 PDT 
<rdar://problem/43157814>