Bug 188462 - Add ability to ignore process prewarming for launch time benchmark
Summary: Add ability to ignore process prewarming for launch time benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Richards
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-09 17:48 PDT by Ben Richards
Modified: 2018-08-10 11:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.47 KB, patch)
2018-08-09 18:11 PDT, Ben Richards 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Richards 2018-08-09 17:48:57 PDT 
Add ability to ignore process prewarming for launch time benchmark
Comment 1 Ben Richards 2018-08-09 18:11:43 PDT 
Created attachment 346883 [details]
Patch
Comment 2 WebKit Commit Bot 2018-08-09 21:53:49 PDT 
Comment on attachment 346883 [details]
Patch

Clearing flags on attachment: 346883

Committed r234750: <https://trac.webkit.org/changeset/234750>
Comment 3 WebKit Commit Bot 2018-08-09 21:53:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-08-09 21:54:20 PDT 
<rdar://problem/43126381>
Comment 5 Truitt Savell 2018-08-10 09:26:17 PDT 
Reverted r234750 for reason:

Caused 185 perf test failures.

Committed r234757: <https://trac.webkit.org/changeset/234757>
Comment 6 Truitt Savell 2018-08-10 10:35:26 PDT 
(In reply to Truitt Savell from comment #5)
> Reverted r234750 for reason:
> 
> Caused 185 perf test failures.
> 
> Committed r234757: <https://trac.webkit.org/changeset/234757>

I apologize, I was wrong with this rollout.
Comment 7 Ben Richards 2018-08-10 10:48:31 PDT 
No worries. Can we reland this?
Comment 8 Truitt Savell 2018-08-10 10:49:30 PDT 
yes we should land it again
Comment 9 EWS 2018-08-10 10:51:43 PDT 
Comment on attachment 346883 [details]
Patch

Rejecting attachment 346883 [details] from commit-queue.

benton_richards@apple.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 10 WebKit Commit Bot 2018-08-10 10:55:50 PDT 
Comment on attachment 346883 [details]
Patch

Rejecting attachment 346883 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 346883, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in PerformanceTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/8820578
Comment 11 WebKit Commit Bot 2018-08-10 11:23:56 PDT 
Comment on attachment 346883 [details]
Patch

Clearing flags on attachment: 346883

Committed r234764: <https://trac.webkit.org/changeset/234764>
Comment 12 WebKit Commit Bot 2018-08-10 11:23:58 PDT 
All reviewed patches have been landed.  Closing bug.