Bug 188439 - [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
Summary: [iOS WK2] Rename and refactor DataInteractionTests and DataInteractionSimulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-09 08:09 PDT by Wenson Hsieh
Modified: 2018-10-01 13:56 PDT (History)
7 users (show)

See Also:

Attachments
Patch (290.83 KB, patch)
2018-08-09 08:17 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix macOS builds (291.11 KB, patch)
2018-08-09 08:41 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rename to DragAndDropSimulator (300.34 KB, patch)
2018-08-09 09:45 PDT, Wenson Hsieh 		aestes: review+
Details | Formatted Diff | Diff
Patch for landing (300.36 KB, patch)
2018-08-09 11:21 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-08-09 08:09:11 PDT 
Rename DataInteractionSimulator to DraggingSimulator, and make DraggingSimulator cross-platform.
Comment 1 Wenson Hsieh 2018-08-09 08:17:12 PDT 
Created attachment 346836 [details]
Patch
Comment 2 Wenson Hsieh 2018-08-09 08:41:50 PDT 
Created attachment 346837 [details]
Fix macOS builds
Comment 3 Megan Gardner 2018-08-09 09:38:16 PDT 
DragAndDropSimulator seems like it would be a better rename than just DraggingSimulator, since we are simulating both dragging and dropping.
Comment 4 Wenson Hsieh 2018-08-09 09:40:44 PDT 
(In reply to Megan Gardner from comment #3)
> DragAndDropSimulator seems like it would be a better rename than just
> DraggingSimulator, since we are simulating both dragging and dropping.

I considered this, but went with DraggingSimulator because it sounded more pleasant. But I don't have strong opinions either way — I'll go with DragAndDropSimulator.
Comment 5 Wenson Hsieh 2018-08-09 09:45:34 PDT 
Created attachment 346838 [details]
Rename to DragAndDropSimulator
Comment 6 Megan Gardner 2018-08-09 09:48:16 PDT 
r=me unofficial
Comment 7 Andy Estes 2018-08-09 10:19:46 PDT 
Comment on attachment 346838 [details]
Rename to DragAndDropSimulator

rs=me
Comment 8 Wenson Hsieh 2018-08-09 11:21:51 PDT 
Created attachment 346849 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2018-08-09 12:02:28 PDT 
Comment on attachment 346849 [details]
Patch for landing

Clearing flags on attachment: 346849

Committed r234731: <https://trac.webkit.org/changeset/234731>
Comment 10 Radar WebKit Bug Importer 2018-10-01 13:56:41 PDT 
<rdar://problem/44919982>