Currently EWS bots build and test on same machine. This is not very efficient. We should instead build (and upload) the archive and re-use it for multiple types of tests (e.g.: WK1, WK2, API tests). This would improve the overall system efficiency by reducing the number of builds while producing same kind of output. This would also improve the overall turn-around time to get EWS results after an engineer uploads a patch. This bug tracks splitting iOS queues in builders and testers.
Created attachment 346745 [details] Proposed patch Sample run: iOS-11-Build-EWS: http://ews-build.webkit-uat.org/#/builders/24/builds/12 iOS-11-Simulator-Build-EWS: http://ews-build.webkit-uat.org/#/builders/23/builds/13 iOS-11-Simulator-Tests-EWS: http://ews-build.webkit-uat.org/#/builders/22/builds/11
Attachment 346745 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:93: [TestsFactory.getProduct] Undefined variable 'DownloadBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:94: [TestsFactory.getProduct] Undefined variable 'ExtractBuiltProduct' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:100: [TestsFactory.__init__] self.LayoutTestClass is not callable [pylint/E1102] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:102: [TestsFactory.__init__] self.APITestClass is not callable [pylint/E1102] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:119: [APITestsFactory] Undefined variable 'RunAPITests' [pylint/E0602] [5] ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:131: [iOSTestsFactory] Undefined variable 'RunWebKitTests' [pylint/E0602] [5] Total errors found: 6 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 346745 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=346745&action=review > Tools/BuildSlaveSupport/ews-build/factories.py:88 > +class TestsFactory(Factory): We use BuildFactory (singular)... maybe we should use TestFactory (singular) here as well? TestsFactory has a weird pronunciation.
Created attachment 346981 [details] Updated patch > We use BuildFactory (singular)... maybe we should use TestFactory (singular) here as well? Done.
Comment on attachment 346981 [details] Updated patch Clearing flags on attachment: 346981 Committed r234785: <https://trac.webkit.org/changeset/234785>
All reviewed patches have been landed. Closing bug.
<rdar://problem/43193062>