RESOLVED INVALID188388
REGRESSION(r225765) WKWebViewConfiguration should not keep a strong reference to a WebPageGroup 
https://bugs.webkit.org/show_bug.cgi?id=188388
Summary REGRESSION(r225765) WKWebViewConfiguration should not keep a strong reference...
Alex Christensen
Reported 2018-08-07 13:29:00 PDT
REGRESSION(r225765) WKWebViewConfiguration should not keep a strong reference to a WebPageGroup
Attachments
Patch (2.85 KB, patch)
2018-08-07 13:29 PDT, Alex Christensen 		achristensen: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2018-08-07 13:29:55 PDT
Created attachment 346726 [details] Patch
Alex Christensen
Comment 2 2018-08-07 13:29:57 PDT
<rdar://problem/42788651>
Chris Dumez
Comment 3 2018-08-07 13:41:41 PDT
Comment on attachment 346726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346726&action=review > Source/WebKit/ChangeLog:9 > + Doing so caused a reference cycle. Keep an identifier instead. I do not get why this is OK. In particular in this scenario: 1. I create a WKPageGroup 2. I create a WKWebViewConfiguration 3. I set my WKPageGroup on the WKWebViewConfiguration 4. I deref the WKPageGroup since I expect the WKWebViewConfiguration to hold on to it. -> after your change, the WKPageGroup gets destroyed right? 5. I create a WKWebView using my WKWebViewConfiguration -> It does not end up in the WKPageGroup I specified.
Alex Christensen
Comment 4 2018-08-07 14:21:03 PDT
Comment on attachment 346726 [details] Patch Chris is right. This is no good.
Note You need to log in before you can comment on or make changes to this bug.