Bug 188371 - [MiniBrowser][Win] Allow selection of recent user agents
Summary: [MiniBrowser][Win] Allow selection of recent user agents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-06 20:02 PDT by Don Olmstead
Modified: 2018-08-07 07:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.44 KB, patch)
2018-08-06 20:09 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Patch (13.42 KB, patch)
2018-08-06 20:14 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-08-06 20:02:38 PDT 
The user agent strings are ancient in the mini browser implementation.
Comment 1 Don Olmstead 2018-08-06 20:09:29 PDT 
Created attachment 346677 [details]
Patch

Updates to the latest released versions. Adds Edge. Moves the setting through the menu to the common base class.
Comment 2 EWS Watchlist 2018-08-06 20:11:31 PDT 
Attachment 346677 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/win/MiniBrowserLibResource.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Tools/ChangeLog:8:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: spoof, spoof  [changelog/unwantedsecurityterms] [3]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 5 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2018-08-06 20:14:15 PDT 
Created attachment 346678 [details]
Patch
Comment 4 EWS Watchlist 2018-08-06 20:16:46 PDT 
Attachment 346678 [details] did not pass style-queue:


ERROR: Tools/MiniBrowser/win/MiniBrowserLibResource.h:0:  No copyright message found.  You should have a line: "Copyright [year] <Copyright Owner>"  [legal/copyright] [5]
ERROR: Tools/ChangeLog:8:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: spoof, spoof  [changelog/unwantedsecurityterms] [3]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:26:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Tools/MiniBrowser/win/BrowserWindow.cpp:27:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 4 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2018-08-07 07:36:41 PDT 
Comment on attachment 346678 [details]
Patch

Clearing flags on attachment: 346678

Committed r234650: <https://trac.webkit.org/changeset/234650>
Comment 6 WebKit Commit Bot 2018-08-07 07:36:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-08-07 07:37:26 PDT 
<rdar://problem/43005476>