Bug 188354 - Make RenderObject noncopyable
Summary: Make RenderObject noncopyable
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-06 13:31 PDT by Alex Christensen
Modified: 2018-08-07 16:15 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.11 KB, patch)
2018-08-06 13:31 PDT, Alex Christensen 		cdumez: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-08-06 13:31:32 PDT 
Make RenderObject noncopyable
Comment 1 Alex Christensen 2018-08-06 13:31:53 PDT 
Created attachment 346649 [details]
Patch
Comment 2 Chris Dumez 2018-08-07 16:06:53 PDT 
Comment on attachment 346649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review

> Source/WebCore/rendering/RenderObject.h:107
> +    WTF_MAKE_NONCOPYABLE(RenderObject);

It is already uncopyable given this data member:
Node& m_node;
Comment 3 Chris Dumez 2018-08-07 16:15:00 PDT 
Comment on attachment 346649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review

>> Source/WebCore/rendering/RenderObject.h:107
>> +    WTF_MAKE_NONCOPYABLE(RenderObject);
> 
> It is already uncopyable given this data member:
> Node& m_node;

See following review comment by Darin:
https://bugs.webkit.org/show_bug.cgi?id=158111#c45