WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
188354
Make RenderObject noncopyable
https://bugs.webkit.org/show_bug.cgi?id=188354
Summary
Make RenderObject noncopyable
Alex Christensen
Reported
2018-08-06 13:31:32 PDT
Make RenderObject noncopyable
Attachments
Patch
(1.11 KB, patch)
2018-08-06 13:31 PDT
,
Alex Christensen
cdumez
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2018-08-06 13:31:53 PDT
Created
attachment 346649
[details]
Patch
Chris Dumez
Comment 2
2018-08-07 16:06:53 PDT
Comment on
attachment 346649
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=346649&action=review
> Source/WebCore/rendering/RenderObject.h:107 > + WTF_MAKE_NONCOPYABLE(RenderObject);
It is already uncopyable given this data member: Node& m_node;
Chris Dumez
Comment 3
2018-08-07 16:15:00 PDT
Comment on
attachment 346649
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=346649&action=review
>> Source/WebCore/rendering/RenderObject.h:107 >> + WTF_MAKE_NONCOPYABLE(RenderObject); > > It is already uncopyable given this data member: > Node& m_node;
See following review comment by Darin:
https://bugs.webkit.org/show_bug.cgi?id=158111#c45
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug