Bug 188345 - Add WinCairo to the flakiness dashboard
Summary: Add WinCairo to the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on: 187973
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-06 04:06 PDT by Fujii Hironori
Modified: 2018-10-10 18:26 PDT (History)
5 users (show)

See Also:

Attachments
WIP patch (7.43 KB, patch)
2018-08-06 04:07 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
WIP patch (4.66 KB, patch)
2018-08-06 04:08 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
WIP patch (4.66 KB, patch)
2018-08-09 23:31 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
WIP patch (4.67 KB, patch)
2018-08-20 21:15 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Patch (2.61 KB, patch)
2018-10-09 20:27 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2018-08-06 04:06:13 PDT 
Add WinCairo to the flakiness dashboard

See Also:
* Bug 173365: Add WPE to the flakiness dashboard
Comment 1 Fujii Hironori 2018-08-06 04:07:10 PDT 
Created attachment 346621 [details]
WIP patch
Comment 2 Fujii Hironori 2018-08-06 04:08:25 PDT 
Created attachment 346622 [details]
WIP patch
Comment 3 Fujii Hironori 2018-08-06 23:30:17 PDT 
Expectation doesn't appear on Results view.
I don't know why because I don't understand flakiness_dashboard at all. But, I guess I need to fix Bug 187973 beforehand.

screenshot: https://photos.app.goo.gl/1rZ6z5oxboKbwN4j9
Comment 4 Fujii Hironori 2018-08-09 22:13:02 PDT 
Oh, no. Expectations still don't appear even after Bug 187973 is fixed. It is irrelevant. I'm doomed to debug.
Comment 5 Fujii Hironori 2018-08-09 23:31:27 PDT 
Created attachment 346896 [details]
WIP patch

Fixed the issue.
Comment 6 Fujii Hironori 2018-08-20 21:15:51 PDT 
Created attachment 347606 [details]
WIP patch
Comment 7 Fujii Hironori 2018-10-09 20:27:25 PDT 
Created attachment 351938 [details]
Patch
Comment 8 Fujii Hironori 2018-10-10 18:25:58 PDT 
Comment on attachment 351938 [details]
Patch

Clearing flags on attachment: 351938

Committed r237023: <https://trac.webkit.org/changeset/237023>
Comment 9 Fujii Hironori 2018-10-10 18:26:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-10-10 18:26:23 PDT 
<rdar://problem/45180827>