Bug 188319 - [LFC][BFC] contentHeightForFormattingContextRoot uses the wrong coordinate system to compute the height.
Summary: [LFC][BFC] contentHeightForFormattingContextRoot uses the wrong coordinate sy...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-03 13:04 PDT by zalan
Modified: 2018-08-05 16:22 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.83 KB, patch)
2018-08-03 13:08 PDT, zalan 		koivisto: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.92 MB, application/zip)
2018-08-03 18:48 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-03 13:04:42 PDT 
Display::Box::marginBox vs Display::Box::rectWithMargin
Comment 1 zalan 2018-08-03 13:08:17 PDT 
Created attachment 346542 [details]
Patch
Comment 2 EWS Watchlist 2018-08-03 18:48:22 PDT 
Comment on attachment 346542 [details]
Patch

Attachment 346542 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8756996

New failing tests:
legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html
Comment 3 EWS Watchlist 2018-08-03 18:48:33 PDT 
Created attachment 346575 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 zalan 2018-08-05 16:20:03 PDT 
Committed r234584: <https://trac.webkit.org/changeset/234584>
Comment 5 Radar WebKit Bug Importer 2018-08-05 16:22:12 PDT 
<rdar://problem/42952440>