Bug 188276 - AX: [iOS] add support to return the attributed string under the element
Summary: AX: [iOS] add support to return the attributed string under the element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-02 14:07 PDT by Nan Wang
Modified: 2018-08-02 16:54 PDT (History)
10 users (show)

See Also:

Attachments
patch (17.12 KB, patch)
2018-08-02 14:20 PDT, Nan Wang 		cfleizach: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2018-08-02 14:07:27 PDT 
Currently we only have attributedStringForRange:(NSRange)range, and it's using the top document and TextIterator to figure out the right start/end point.
For the case where we want to get the attributed string under some element, we shouldn't do such redundant work to walk from the beginning of the document to figure out the right range.
Comment 1 Radar WebKit Bug Importer 2018-08-02 14:07:42 PDT 
<rdar://problem/42872357>
Comment 2 Nan Wang 2018-08-02 14:20:41 PDT 
Created attachment 346416 [details]
patch
Comment 3 chris fleizach 2018-08-02 16:41:58 PDT 
Comment on attachment 346416 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346416&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2530
> +        

white space
Comment 4 Nan Wang 2018-08-02 16:54:47 PDT 
Committed r234526: <https://trac.webkit.org/changeset/234526>