Bug 188249 - [LFC][Floating] Convert all coordinates relative to the formatting context root.
Summary: [LFC][Floating] Convert all coordinates relative to the formatting context root.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-01 21:38 PDT by zalan
Modified: 2018-08-02 07:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (28.00 KB, patch)
2018-08-01 21:46 PDT, zalan 		koivisto: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (13.03 MB, application/zip)
2018-08-02 01:43 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-01 21:38:33 PDT 
to ease up on the computation logic.
Comment 1 zalan 2018-08-01 21:46:36 PDT 
Created attachment 346357 [details]
Patch
Comment 2 EWS Watchlist 2018-08-02 01:43:10 PDT 
Comment on attachment 346357 [details]
Patch

Attachment 346357 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8735317

New failing tests:
imported/blink/transitions/unprefixed-transform.html
legacy-animation-engine/imported/blink/transitions/unprefixed-transform.html
Comment 3 EWS Watchlist 2018-08-02 01:43:21 PDT 
Created attachment 346365 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Antti Koivisto 2018-08-02 07:24:59 PDT 
Comment on attachment 346357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346357&action=review

> Source/WebCore/ChangeLog:8
> +        The idea here is that all the float related computation should be happening in the same coordinate sytem.

spelling "system"
Comment 5 zalan 2018-08-02 07:28:35 PDT 
Committed r234499: <https://trac.webkit.org/changeset/234499>
Comment 6 Radar WebKit Bug Importer 2018-08-02 07:30:18 PDT 
<rdar://problem/42855390>