Bug 188232 - [LFC][Floating] Revert back to only one list for the all the floatings.
Summary: [LFC][Floating] Revert back to only one list for the all the floatings.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-08-01 12:35 PDT by zalan
Modified: 2018-08-01 20:32 PDT (History)
4 users (show)

See Also:

Attachments
Patch (13.52 KB, patch)
2018-08-01 12:41 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (13.57 KB, patch)
2018-08-01 13:30 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-08-01 12:35:02 PDT 
to simplify implementation. if it ends up being a perf bottleneck, we can still split it into left and right floatings.
Comment 1 zalan 2018-08-01 12:41:15 PDT 
Created attachment 346289 [details]
Patch
Comment 2 zalan 2018-08-01 13:30:23 PDT 
Created attachment 346293 [details]
Patch
Comment 3 Antti Koivisto 2018-08-01 13:55:08 PDT 
Comment on attachment 346293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346293&action=review

> Source/WebCore/layout/FloatingState.h:64
> +    FloatingList m_floatings;

Is "floatings" a spec term or something? To me "floats" sounds better.
Comment 4 zalan 2018-08-01 14:37:06 PDT 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 346293 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346293&action=review
> 
> > Source/WebCore/layout/FloatingState.h:64
> > +    FloatingList m_floatings;
> 
> Is "floatings" a spec term or something? To me "floats" sounds better.
spec calls floats in many ways:
"The most interesting characteristic of a float (or "floated" or "floating" box).."
I actually prefer "floats" too. AFAIR the only reason why I picked floating was not to confuse it with the primitive type, but I guess it's really hard to confuse them in this context. I'll rename them in a separate patch.
Comment 5 zalan 2018-08-01 14:46:57 PDT 
Committed r234481: <https://trac.webkit.org/changeset/234481>
Comment 6 Radar WebKit Bug Importer 2018-08-01 20:32:46 PDT 
<rdar://problem/42840449>