Bug 188201 - [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous
Summary: [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-31 11:16 PDT by Yusuke Suzuki
Modified: 2018-07-31 11:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2018-07-31 11:19 PDT, Yusuke Suzuki 		keith_miller: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-31 11:16:50 PDT 
[JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous
Comment 1 Yusuke Suzuki 2018-07-31 11:19:41 PDT 
Created attachment 346181 [details]
Patch
Comment 2 Keith Miller 2018-07-31 11:34:02 PDT 
Comment on attachment 346181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review

r=me.

> Source/JavaScriptCore/runtime/JSObject.cpp:400
> +        // that can happen when the butterfly is used for array storage.

Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage.
Comment 3 Yusuke Suzuki 2018-07-31 11:39:17 PDT 
Comment on attachment 346181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review

Thanks!

>> Source/JavaScriptCore/runtime/JSObject.cpp:400
>> +        // that can happen when the butterfly is used for array storage.
> 
> Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage.

Sounds nice. Added.
Comment 4 Yusuke Suzuki 2018-07-31 11:48:49 PDT 
Committed r234434: <https://trac.webkit.org/changeset/234434>
Comment 5 Radar WebKit Bug Importer 2018-07-31 11:49:26 PDT 
<rdar://problem/42781022>