We don't need to call RenderTheme::platformColorsDidChange() during printing anymore. RenderTheme caches dark and light mode colors separately. Also platformColorsDidChange() calls Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment() which is very heavy handed and can mess up printing operations. rdar://problem/42360070
Created attachment 346106 [details] Patch
Comment on attachment 346106 [details] Patch Attachment 346106 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8703917 New failing tests: inspector/page/media-query-list-listener-exception.html
Created attachment 346117 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346106 [details] Patch Attachment 346106 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8703930 New failing tests: inspector/page/media-query-list-listener-exception.html
Created attachment 346120 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346106 [details] Patch Attachment 346106 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8704032 New failing tests: inspector/page/media-query-list-listener-exception.html
Created attachment 346125 [details] Archive of layout-test-results from ews112 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 346130 [details] Patch
Comment on attachment 346130 [details] Patch Clearing flags on attachment: 346130 Committed r234432: <https://trac.webkit.org/changeset/234432>
All reviewed patches have been landed. Closing bug.