Created attachment 346056 [details]
Patch

Hi Jonathan, could you review this patch. You seems the best person because you did Bug 160943.

Comment on attachment 346056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review

> Tools/Scripts/webkitpy/port/server_process.py:326
> +            _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode)

I think it should say 'This test marked as a crash because of failure to poll the server process (return code was %).'

Comment on attachment 346056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review

Thank you for the review.

>> Tools/Scripts/webkitpy/port/server_process.py:326
>> +            _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode)
> 
> I think it should say 'This test marked as a crash because of failure to poll the server process (return code was %).'

Make sense. Will Fix.

Created attachment 346162 [details]
Patch

* Addressed the review feedback.

Comment on attachment 346162 [details]
Patch

Clearing flags on attachment: 346162

Committed r234430: <https://trac.webkit.org/changeset/234430>

All reviewed patches have been landed.  Closing bug.

<rdar://problem/42779206>

I think this is/was a good idea, but I want to make sure that you're aware of a notable limitation: If we're controlling a device (iOS Simulator is the most notable example of this) we don't have a 'real' Popen object and can't determine what the actual return code is, in which case we will assign a returncode of 1.

Thank you for the feedback. I didn't know that. I will check it.