Bug 188126 - Web Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is too light
Summary: Web Inspector: Dark Mode: SourceCodeTextEditor error/warning text widget is t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on: 188119
Blocks:
  Show dependency tree / graph
 
Reported: 2018-07-27 14:28 PDT by Matt Baker
Modified: 2018-08-09 14:47 PDT (History)
3 users (show)

See Also:

Attachments
[Image] SourceCodeTextEditor error message widget (304.70 KB, image/png)
2018-07-27 14:28 PDT, Matt Baker 		no flags Details
Patch (1.59 KB, patch)
2018-08-03 16:47 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] With patch applied (248.17 KB, image/png)
2018-08-03 16:48 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-27 14:28:27 PDT 
Created attachment 345953 [details]
[Image] SourceCodeTextEditor error message widget

Summary:
SourceCodeTextEditor error/warning text widget is too light.

This affects the expanded widget only, the inline message text is styled correctly.
Comment 1 Radar WebKit Bug Importer 2018-07-27 14:28:54 PDT 
<rdar://problem/42674963>
Comment 2 Nikita Vasilyev 2018-08-03 16:47:23 PDT 
Created attachment 346562 [details]
Patch
Comment 3 Nikita Vasilyev 2018-08-03 16:48:36 PDT 
Created attachment 346563 [details]
[Image] With patch applied
Comment 4 Nikita Vasilyev 2018-08-03 16:53:38 PDT 
Comment on attachment 346562 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346562&action=review

> Source/WebInspectorUI/UserInterface/Views/DarkMode.css:1048
>      .source-code.text-editor > .CodeMirror .issue-widget.inline.error {

We can't remove the selector for the inline widget. Removing this line would cause the light mode rule to have higher priority.

Alternatively, I could have used !important:

    .source-code.text-editor > .CodeMirror .issue-widget.error {
        background-color: var(--error-background-color) !important;
    }

But I try to avoid it whenever possible.
Comment 5 Matt Baker 2018-08-09 14:19:51 PDT 
Comment on attachment 346562 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2018-08-09 14:47:07 PDT 
Comment on attachment 346562 [details]
Patch

Clearing flags on attachment: 346562

Committed r234736: <https://trac.webkit.org/changeset/234736>
Comment 7 WebKit Commit Bot 2018-08-09 14:47:09 PDT 
All reviewed patches have been landed.  Closing bug.