Bug 188120 - Web Inspector: Dark Mode: disabled breakpoints banner is too light
Summary: Web Inspector: Dark Mode: disabled breakpoints banner is too light
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-27 12:57 PDT by Matt Baker
Modified: 2018-08-01 11:09 PDT (History)
4 users (show)

See Also:

Attachments
[Image] disabled breakpoints banner (505.36 KB, image/png)
2018-07-27 12:57 PDT, Matt Baker 		no flags Details
Patch (1.55 KB, patch)
2018-07-31 17:47 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Image] With patch applied (58.86 KB, image/png)
2018-07-31 17:48 PDT, Nikita Vasilyev 		no flags Details
Archive of layout-test-results from ews206 for win-future (12.92 MB, application/zip)
2018-07-31 23:51 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2018-07-27 12:57:59 PDT 
Created attachment 345941 [details]
[Image] disabled breakpoints banner

Summary:
Disabled breakpoints banner is too light.

The banner is shown whenever breakpoints are disabled from the Debugger sidebar panel.
Comment 1 Radar WebKit Bug Importer 2018-07-27 12:58:22 PDT 
<rdar://problem/42671348>
Comment 2 Nikita Vasilyev 2018-07-31 17:47:02 PDT 
Created attachment 346237 [details]
Patch

Use the same styles as in Bug 187792 - Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message.
Comment 3 Nikita Vasilyev 2018-07-31 17:48:00 PDT 
Created attachment 346238 [details]
[Image] With patch applied
Comment 4 EWS Watchlist 2018-07-31 23:51:18 PDT 
Comment on attachment 346237 [details]
Patch

Attachment 346237 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8720731

New failing tests:
imported/blink/transitions/unprefixed-transform.html
Comment 5 EWS Watchlist 2018-07-31 23:51:29 PDT 
Created attachment 346263 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Matt Baker 2018-08-01 10:41:36 PDT 
Comment on attachment 346237 [details]
Patch

r=me, looks great!
Comment 7 WebKit Commit Bot 2018-08-01 11:09:44 PDT 
Comment on attachment 346237 [details]
Patch

Clearing flags on attachment: 346237

Committed r234464: <https://trac.webkit.org/changeset/234464>
Comment 8 WebKit Commit Bot 2018-08-01 11:09:46 PDT 
All reviewed patches have been landed.  Closing bug.