RESOLVED DUPLICATE of bug 190542188112
Web Inspector: Dark Mode: highlighted search results are too light 
https://bugs.webkit.org/show_bug.cgi?id=188112
Summary Web Inspector: Dark Mode: highlighted search results are too light
Matt Baker
Reported 2018-07-27 12:26:24 PDT
Created attachment 345934 [details] [Image] TextEditor search results Summary: Highlighted search results are too light. From SearchHighlightingDefaultTheme.css:93: .supports-find-banner.showing-find-banner.syntax-highlighted .search-result, .supports-find-banner.showing-find-banner .syntax-highlighted .search-result { background-color: hsla(53, 83%, 53%, 0.2); border-bottom: 1px solid hsl(47, 82%, 60%); } See attached screenshot: - The search-result background-color property uses opacity, which is hard to see against the dark background. - The search-result color is pricking up dark mode's lighter --text-color as well.
Attachments
[Image] TextEditor search results (478.76 KB, image/png)
2018-07-27 12:26 PDT, Matt Baker 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-27 12:26:57 PDT
<rdar://problem/42670380>
Nikita Vasilyev
Comment 2 2018-07-31 17:20:03 PDT
The native *unfocused* text selection color is a light gray. It shines through the search highlight background. Perhaps the least invasive solution would be to make the search highlight text color dark. (Wouldn't it be nice to read system colors and pick black/white text color accordingly? Maybe one day.)
Nikita Vasilyev
Comment 3 2018-12-18 23:36:21 PST
(In reply to Nikita Vasilyev from comment #2) > The native *unfocused* text selection color is a light gray. [...] I was wrong. It was CodeMirror's color. *** This bug has been marked as a duplicate of bug 190542 ***
Note You need to log in before you can comment on or make changes to this bug.