Bug 188065 - arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array.
Summary: arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-26 11:16 PDT by Mark Lam
Modified: 2020-04-30 00:06 PDT (History)
8 users (show)

See Also:

Attachments
proposed patch. (4.43 KB, patch)
2018-07-26 11:24 PDT, Mark Lam 		saam: review+
Details | Formatted Diff | Diff
patch for landing. (4.40 KB, patch)
2018-07-26 11:33 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2018-07-26 11:16:33 PDT 
<rdar://problem/42515726>
Comment 1 Mark Lam 2018-07-26 11:24:32 PDT 
Created attachment 345853 [details]
proposed patch.
Comment 2 Saam Barati 2018-07-26 11:29:13 PDT 
Comment on attachment 345853 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307
> +template<typename T, bool isDouble = std::is_same<T, double>::value>

why do you need isDouble?

> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308
> +void copyElements(T* buffer, unsigned offset, void* source, unsigned sourceSize, IndexingType sourceType)

ALWAYS_INLINE?
Comment 3 Mark Lam 2018-07-26 11:30:14 PDT 
Comment on attachment 345853 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review

>> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307
>> +template<typename T, bool isDouble = std::is_same<T, double>::value>
> 
> why do you need isDouble?

Oops ... old code that is now solved by a superior method.  Will delete this.

>> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308
>> +void copyElements(T* buffer, unsigned offset, void* source, unsigned sourceSize, IndexingType sourceType)
> 
> ALWAYS_INLINE?

OK.
Comment 4 Mark Lam 2018-07-26 11:33:05 PDT 
Created attachment 345854 [details]
patch for landing.
Comment 5 Mark Lam 2018-07-26 12:50:06 PDT 
Thanks for the review.  Landed in r234269: <http://trac.webkit.org/r234269>.