Bug 188062 - Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction
Summary: Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-07-26 10:17 PDT by Sam Weinig
Modified: 2018-07-27 10:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (21.76 KB, patch)
2018-07-26 10:20 PDT, Sam Weinig
darin: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews205 for win-future (12.90 MB, application/zip)
2018-07-26 14:10 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2018-07-26 10:17:07 PDT
Reduce unnecessary copying of EditingStyles on ApplyStyleCommand construction
Comment 1 Sam Weinig 2018-07-26 10:20:18 PDT
Created attachment 345850 [details]
Patch
Comment 2 EWS Watchlist 2018-07-26 14:10:02 PDT
Comment on attachment 345850 [details]
Patch

Attachment 345850 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8664982

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 3 EWS Watchlist 2018-07-26 14:10:14 PDT
Created attachment 345869 [details]
Archive of layout-test-results from ews205 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews205  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Darin Adler 2018-07-26 23:27:42 PDT
Comment on attachment 345850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345850&action=review

> Source/WebCore/ChangeLog:28
> +        * editing/EditorCommand.cpp:
> +        (WebCore::executeMakeTextWritingDirectionLeftToRight):
> +        (WebCore::executeMakeTextWritingDirectionNatural):
> +        (WebCore::executeMakeTextWritingDirectionRightToLeft):

This is a not-particularly-closely-related (minor) refactoring, not mentioned in the change log.
Comment 5 Sam Weinig 2018-07-27 10:02:48 PDT
(In reply to Darin Adler from comment #4)
> Comment on attachment 345850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345850&action=review
> 
> > Source/WebCore/ChangeLog:28
> > +        * editing/EditorCommand.cpp:
> > +        (WebCore::executeMakeTextWritingDirectionLeftToRight):
> > +        (WebCore::executeMakeTextWritingDirectionNatural):
> > +        (WebCore::executeMakeTextWritingDirectionRightToLeft):
> 
> This is a not-particularly-closely-related (minor) refactoring, not
> mentioned in the change log.

Yeah, I'm going to beef up the changelog before landing.