Allow ActiveDOMObject's canSuspend / suspend / resume overrides to destroy ActiveDOMObjects. There is a good reason to prevent construction of new ActiveDOMObjects from these overrides as this would cause break PageCache logic. However, it is fine for these overrides to destroy existing ActiveDOMObjects as long as we make our code iterating over ActiveDOMObjects support it.
Created attachment 345794 [details] Patch
Created attachment 345798 [details] Patch
Comment on attachment 345798 [details] Patch Rejecting attachment 345798 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 345798, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=345798&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=188025&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 345798 from bug 188025. Fetching: https://bugs.webkit.org/attachment.cgi?id=345798 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: 98375d5bde7b8b5deb2161c8170939887189f626 and refs/remotes/origin/master differ, using rebase: :040000 040000 c5a29e897de220921e005b5172e9e434ec122c72 09b5c312726605cb3511c4872bb8e2b3b16ce04d M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog ERROR from SVN: Item is out of date: File '/trunk/Source/WebCore/ChangeLog' is out of date W: 98375d5bde7b8b5deb2161c8170939887189f626 and refs/remotes/origin/master differ, using rebase: :040000 040000 c5a29e897de220921e005b5172e9e434ec122c72 09b5c312726605cb3511c4872bb8e2b3b16ce04d M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 49e70b34d9f..d294af02a32 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 234219 = 49e70b34d9fd9d0b75ac25fc2aafd34a8f6fd3b6 r234220 = 9c74f145f3f5375c8d17382ddaa69790c6b7b259 r234222 = c3452943748c48453648405a5de829db87d9a580 r234223 = d294af02a323a020fb8a1f7d16c748d30047c272 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/8656037
Comment on attachment 345798 [details] Patch Clearing flags on attachment: 345798 Committed r234226: <https://trac.webkit.org/changeset/234226>
All reviewed patches have been landed. Closing bug.
<rdar://problem/42608604>