Bug 187997 - [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
Summary: [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-25 04:17 PDT by Zan Dobersek
Modified: 2018-07-25 06:27 PDT (History)
5 users (show)

See Also:

Attachments
Patch (17.51 KB, patch)
2018-07-25 04:29 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (17.28 KB, patch)
2018-07-25 06:23 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-07-25 04:17:29 PDT 
[WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
Comment 1 Zan Dobersek 2018-07-25 04:29:05 PDT 
Created attachment 345752 [details]
Patch
Comment 2 Carlos Garcia Campos 2018-07-25 04:37:39 PDT 
Comment on attachment 345752 [details]
Patch

Thanks!
Comment 3 Carlos Garcia Campos 2018-07-25 04:38:47 PDT 
I think we should fix wpe_view_backend_exportable_fdo_create() in any case, or remove it.
Comment 4 Adrian Perez 2018-07-25 04:45:19 PDT 
Comment on attachment 345752 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345752&action=review

Just one small nit, informal r+ otherwise.

> Tools/flatpak/org.webkit.WPE.yaml:44
> +    - /app/webkit/Tools/Scripts/build-webkit --wpe --prefix=/app

Probably your text editor added the newline at the end of file
automatically. This is unrelated to the rest of the patch.
Comment 5 Zan Dobersek 2018-07-25 06:23:30 PDT 
Created attachment 345756 [details]
Patch for landing
Comment 6 Zan Dobersek 2018-07-25 06:26:08 PDT 
Comment on attachment 345756 [details]
Patch for landing

Clearing flags on attachment: 345756

Committed r234193: <https://trac.webkit.org/changeset/234193>
Comment 7 Zan Dobersek 2018-07-25 06:26:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-25 06:27:20 PDT 
<rdar://problem/42580553>