Bug 187905 - [MediaStream] Restructure getDisplayMedia classes
Summary: [MediaStream] Restructure getDisplayMedia classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-23 07:12 PDT by Eric Carlson
Modified: 2018-07-24 12:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (26.89 KB, patch)
2018-07-23 08:09 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (28.02 KB, patch)
2018-07-24 06:09 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (27.76 KB, patch)
2018-07-24 07:08 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Build fix (1.56 KB, patch)
2018-07-24 11:52 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-07-23 07:12:43 PDT 
Move code that can be shared to the base classes, clean up existing code.
Comment 1 Eric Carlson 2018-07-23 08:09:23 PDT 
Created attachment 345574 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-07-23 08:10:17 PDT 
<rdar://problem/42500215>
Comment 3 Eric Carlson 2018-07-24 06:09:04 PDT 
Created attachment 345666 [details]
Patch for landing
Comment 4 Eric Carlson 2018-07-24 07:08:56 PDT 
Created attachment 345671 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-07-24 08:04:50 PDT 
Comment on attachment 345671 [details]
Patch for landing

Clearing flags on attachment: 345671

Committed r234146: <https://trac.webkit.org/changeset/234146>
Comment 6 Eric Carlson 2018-07-24 11:52:04 PDT 
Created attachment 345696 [details]
Build fix
Comment 7 WebKit Commit Bot 2018-07-24 12:31:11 PDT 
Comment on attachment 345696 [details]
Build fix

Clearing flags on attachment: 345696

Committed r234164: <https://trac.webkit.org/changeset/234164>
Comment 8 WebKit Commit Bot 2018-07-24 12:31:12 PDT 
All reviewed patches have been landed.  Closing bug.