Bug 187892 - Rename Document::firstPartyForSameSiteCookies() to siteForCookies()
Summary: Rename Document::firstPartyForSameSiteCookies() to siteForCookies()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-22 15:48 PDT by Daniel Bates
Modified: 2018-07-24 09:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.25 KB, patch)
2018-07-22 15:52 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews206 for win-future (12.91 MB, application/zip)
2018-07-23 23:31 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2018-07-22 15:48:51 PDT 
Rename Document::firstPartyForSameSiteCookies() to siteForCookies() to match the concept described in the Same-Site RFCs, the latest draft now being <https://httpwg.org/http-extensions/rfc6265bis.html>. Also rename the similarly named setter on Document.
Comment 1 Daniel Bates 2018-07-22 15:52:42 PDT 
Created attachment 345544 [details]
Patch
Comment 2 EWS Watchlist 2018-07-23 23:31:46 PDT 
Comment on attachment 345544 [details]
Patch

Attachment 345544 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8634388

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html
Comment 3 EWS Watchlist 2018-07-23 23:31:58 PDT 
Created attachment 345639 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 Daniel Bates 2018-07-24 09:27:33 PDT 
Comment on attachment 345544 [details]
Patch

Clearing flags on attachment: 345544

Committed r234148: <https://trac.webkit.org/changeset/234148>
Comment 5 Daniel Bates 2018-07-24 09:27:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-24 09:29:09 PDT 
<rdar://problem/42544012>