Bug 187865 - Refactor the RenderLayer composited phases painting into a separate function
Summary: Refactor the RenderLayer composited phases painting into a separate function
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on: 187841
Blocks: 187898
  Show dependency tree / graph
 
Reported: 2018-07-20 10:56 PDT by Said Abou-Hallawa
Modified: 2018-08-06 16:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch for EWS (267.97 KB, patch)
2018-07-20 11:05 PDT, Said Abou-Hallawa 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Patch for Review (13.25 KB, patch)
2018-07-20 12:18 PDT, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (13.00 MB, application/zip)
2018-07-20 13:58 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2018-07-20 10:56:39 PDT 
The plan is to make RenderLayer::paintLayerContents() choose between different implementations for painting the composited phases. The first implementation is the existing one: multiple passes into the drawing GraphicsContext. In the following patch, a new implementation will be introduced: multiple passes into multiple DisplayLists. Then this implementation will be changed to be: single pass into multiple DisplayLists.
Comment 1 Said Abou-Hallawa 2018-07-20 11:05:10 PDT 
Created attachment 345462 [details]
Patch for EWS
Comment 2 Said Abou-Hallawa 2018-07-20 12:18:49 PDT 
Created attachment 345473 [details]
Patch for Review
Comment 3 EWS Watchlist 2018-07-20 13:58:00 PDT 
Comment on attachment 345462 [details]
Patch for EWS

Attachment 345462 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8602333

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 4 EWS Watchlist 2018-07-20 13:58:12 PDT 
Created attachment 345480 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Radar WebKit Bug Importer 2018-08-06 16:37:04 PDT 
<rdar://problem/42986513>