Bug 187817 - Teach the AWS Lambda to use the [minified]-platforms database
Summary: Teach the AWS Lambda to use the [minified]-platforms database
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 11
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lucas Forschler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-19 13:16 PDT by Lucas Forschler
Modified: 2018-07-19 16:42 PDT (History)
6 users (show)

See Also:

Attachments
patch for review (3.49 KB, patch)
2018-07-19 13:19 PDT, Lucas Forschler 		lforschler: commit-queue-
Details | Formatted Diff | Diff
v2 patch to fix style errors. (3.46 KB, patch)
2018-07-19 13:28 PDT, Lucas Forschler 		ddkilzer: review+
lforschler: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Forschler 2018-07-19 13:16:39 PDT 
When archives are uploaded to S3, we need to keep track of what platforms are available. We can easily do this with the current lambda function which parses the rest of the metadata.
Comment 1 Radar WebKit Bug Importer 2018-07-19 13:17:08 PDT 
<rdar://problem/42396841>
Comment 2 Lucas Forschler 2018-07-19 13:19:06 PDT 
Created attachment 345375 [details]
patch for review
Comment 3 dewei_zhu 2018-07-19 13:20:56 PDT 
Comment on attachment 345375 [details]
patch for review

looks good to me.
Comment 4 EWS Watchlist 2018-07-19 13:22:17 PDT 
Attachment 345375 [details] did not pass style-queue:


ERROR: Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:45:  trailing whitespace  [pep8/W291] [5]
ERROR: Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:53:  trailing whitespace  [pep8/W291] [5]
ERROR: Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:45:  trailing whitespace  [pep8/W291] [5]
ERROR: Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:53:  trailing whitespace  [pep8/W291] [5]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Lucas Forschler 2018-07-19 13:28:35 PDT 
Created attachment 345376 [details]
v2 patch to fix style errors.
Comment 6 David Kilzer (:ddkilzer) 2018-07-19 16:32:26 PDT 
Comment on attachment 345376 [details]
v2 patch to fix style errors.

rs=me
Comment 7 Lucas Forschler 2018-07-19 16:38:22 PDT 
Committed revision 234016.
Comment 8 Aakash Jain 2018-07-19 16:42:25 PDT 
Comment on attachment 345376 [details]
v2 patch to fix style errors.

looks good to me.