Bug 187793 - Hitting RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) under HTMLMediaElement::resume()
Summary: Hitting RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) under HTMLMediaEl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-18 17:27 PDT by Antoine Quint
Modified: 2018-07-19 06:38 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2018-07-18 17:32 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-07-18 17:27:53 PDT 
HTMLMediaElement::resume() may end up calling prepareForLoad() which will end up calling configureMediaControls() which will in turn instantiate the media controls and run JS code, which will trigger RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) in ScriptExecutionContext::didCreateActiveDOMObject(). We need to delay the call to prepareForLoad() in resume().
Comment 1 Antoine Quint 2018-07-18 17:28:03 PDT 
<rdar://problem/42308469>
Comment 2 Antoine Quint 2018-07-18 17:32:12 PDT 
Created attachment 345312 [details]
Patch
Comment 3 Chris Dumez 2018-07-18 18:18:06 PDT 
Comment on attachment 345312 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-07-19 06:38:22 PDT 
Comment on attachment 345312 [details]
Patch

Clearing flags on attachment: 345312

Committed r233982: <https://trac.webkit.org/changeset/233982>
Comment 5 WebKit Commit Bot 2018-07-19 06:38:24 PDT 
All reviewed patches have been landed.  Closing bug.