Bug 187716 - run-leaks should run leaks with --list (on Mojave)
Summary: run-leaks should run leaks with --list (on Mojave)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-16 16:20 PDT by Joseph Pecoraro
Modified: 2018-09-10 10:23 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (9.06 KB, patch)
2018-08-31 10:27 PDT, Alexey Proskuryakov 		lforschler: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-07-16 16:20:11 PDT 
run-leaks should run leaks with --list (on Mojave) or LeaksViewer should parse new format (ROOT leaks)

I think currently on new enough macOS builds or with a new enough Xcode the leaks output will differ such that LeaksViewer's LeaksParserImpl would not be able to parse out individual leaks.
Comment 1 Radar WebKit Bug Importer 2018-07-16 16:20:49 PDT 
<rdar://problem/42261676>
Comment 2 Joseph Pecoraro 2018-07-16 16:59:50 PDT 
Also `parseLeaksOutput` in Tools/Scripts/run-leaks
Comment 3 Alexey Proskuryakov 2018-08-31 10:20:46 PDT 
I don't think that parsing the new format is feasible without deep changes to LeaksViewer.
Comment 4 Alexey Proskuryakov 2018-08-31 10:27:22 PDT 
Created attachment 348647 [details]
proposed patch
Comment 5 Alexey Proskuryakov 2018-08-31 11:27:32 PDT 
Hmm, I got 1.7 GB of memgraphs when running locally. We'll probably need custom aggressive pruning for leaks queue archives for this to be feasible.
Comment 6 Lucas Forschler 2018-09-04 12:14:10 PDT 
Comment on attachment 348647 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348647&action=review

> Tools/ChangeLog:14
> +        (runLeaks): Ad there is no way to test whether the new format is supported in advance,

nit: Ad = Add?
Comment 7 Alexey Proskuryakov 2018-09-04 14:06:50 PDT 
Committed http://trac.webkit.org/r235633
Comment 8 Alexey Proskuryakov 2018-09-04 14:16:14 PDT 
And r235634 for a "print" forgotten in run-leaks.
Comment 9 Joseph Pecoraro 2018-09-10 10:23:06 PDT 
Comment on attachment 348647 [details]
proposed patch

Nice!