Bug 187709 - [JSC] UnlinkedCodeBlock::shrinkToFit miss m_constantIdentifierSets
Summary: [JSC] UnlinkedCodeBlock::shrinkToFit miss m_constantIdentifierSets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-16 13:02 PDT by Yusuke Suzuki
Modified: 2018-07-16 13:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2018-07-16 13:02 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-07-16 13:02:10 PDT 
[JSC] UnlinkedCodeBlock::shrinkToFit miss m_constantIdentifierSets
Comment 1 Yusuke Suzuki 2018-07-16 13:02:33 PDT 
Created attachment 345115 [details]
Patch
Comment 2 Yusuke Suzuki 2018-07-16 13:03:34 PDT 
Comment on attachment 345115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345115&action=review

> Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:392
>      m_expressionInfo.shrinkToFit();

Aligned the order to member definitions.
Comment 3 Mark Lam 2018-07-16 13:07:29 PDT 
Comment on attachment 345115 [details]
Patch

r=me
Comment 4 Yusuke Suzuki 2018-07-16 13:10:12 PDT 
Committed r233862: <https://trac.webkit.org/changeset/233862>
Comment 5 Radar WebKit Bug Importer 2018-07-16 13:13:41 PDT 
<rdar://problem/42252940>