The following layout tests is failing on Sierra WK2 http/tests/websocket/tests/hybi/websocket-cookie-overwrite-behavior.html http/tests/websocket/tests/hybi/websocket-allowed-setting-cookie-as-third-party.html Probable cause: After a change to the tests in r233830 <https://trac.webkit.org/changeset/233830/webkit> These two tests were constantly failing on Sierra WK2. We were advised to skip the test in bug: <https://bugs.webkit.org/show_bug.cgi?id=187541> by John Wilander due to "It's not setting the cookie for the third-party WebSocket so we're failing closed." Which is only an issue with Sierra. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fwebsocket-allowed-setting-cookie-as-third-party.html%20http%2Ftests%2Fwebsocket%2Ftests%2Fhybi%2Fwebsocket-cookie-overwrite-behavior.html
Created attachment 345117 [details] Patch
Looks good to me. Maybe add a comment that these are new tests and that they probably never passed on Sierra.
*probably never would have passed on Sierra.
Taking patch out of commit queue due to other platforms having failures
We have other bugs about these, seems worth cleaning up so that there is no duplication. https://bugs.webkit.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&list_id=3912098&query_format=advanced&short_desc=websocket-cookie-overwrite%20websocket-allowed-setting-cookie-as-third-party&short_desc_type=anywordssubstr
*** This bug has been marked as a duplicate of bug 187541 ***